crypto: use user-facing error for output encoding changes#64692
Open
Archkon wants to merge 1 commit into
Open
Conversation
Replace the internal assertion with ERR_INVALID_ARG_VALUE when the output encoding changes between Cipher or Decipher calls. Document the encoding requirement and update the corresponding tests. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
Member
|
Technically a
semver-major
|
Member
|
Intermittent GHA outages, it's going to be a fun day... |
Member
|
Looks like this will need a push of some description to (hopefully) trigger the workflows. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64692 +/- ##
==========================================
- Coverage 90.14% 90.11% -0.03%
==========================================
Files 741 741
Lines 242112 242114 +2
Branches 45605 45601 -4
==========================================
- Hits 218244 218190 -54
- Misses 15360 15430 +70
+ Partials 8508 8494 -14
🚀 New features to boost your workflow:
|
pimterry
approved these changes
Jul 23, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Jul 23, 2026
Member
|
I'm also fine with this not being semver-major. |
Renegade334
added
the
author ready
panva
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64689