Clarify custom-chain bundler requirements#949
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughCustom chain guidance was added to the README and ChangesCustom chain guidance
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
Summary
Why
Engine supports custom chain overrides, but the UserOp routes still post to
https://{chainId}.bundler.thirdweb.com. In practice that means a custom chain can be valid for normal Engine reads/writes/deployments while still failing for smart wallet flows if hosted bundler support is unavailable.This change keeps the scope narrow and just makes that boundary explicit.
Validation
tsc/biomebinaries before publishPR-Codex overview
This PR enhances error messaging and documentation regarding custom chains in the project. It clarifies the requirements for using smart wallets and UserOp routes with custom chains.
Detailed summary
badChainErrorfunction to include information about bundler support requirements for smart wallet and UserOp routes.README.mdabout custom chains, explaining chain overrides and their dependencies on bundler support.Summary by CodeRabbit
Documentation
Bug Fixes