feat: add operator parameter to vf() for range filters#1813
Conversation
Exposes comparison operators (GreaterThan, LessThan, etc.) on the vf() method of _DataExportOptions. The REST API accepts operator:value encoding for view filters; previously callers had to hand-craft the string themselves. Fixes tableau#1752 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code ReviewSummary: Adds an optional Mechanical checks (on the PR branch): tests pass (42/42), 🔴 Critical: the feature doesn't do what it claimsTableau's REST API documentation for view filters (
View filters ( Given this, I don't think this should merge as-is — it adds a plausible-looking but non-functional API surface that would mislead callers into believing range filtering works when it doesn't. It'd be worth checking with the API/docs team (or re-triaging #1752) on whether there's a different mechanism (e.g. a different endpoint, or dashboard-level filter configuration) that actually supports range filters for PDF/image exports, since Other findings
🤖 Generated with Claude Code |
|
@jacalata not sure how to interpret claude's review findings. Is it missing the fix or do the docs need to updated? |
Summary
operatorparameter toRequestOptions.vf()(and by inheritancePDFRequestOptions,ImageRequestOptions, etc.)operator:value(e.g.gt:1000) matching the REST API's range filter syntaxoperatorpreserves existing exact-match behaviourCloses #1752
Test plan
test_vf_with_operatorintest/test_request_option.pyverifiesgt:1000encodingvftests continue to pass (exact-match unchanged)🤖 Generated with Claude Code