Skip to content

chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid#1397

Open
nschad wants to merge 1 commit into
mainfrom
clarify-todo-encryption
Open

chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid#1397
nschad wants to merge 1 commit into
mainfrom
clarify-todo-encryption

Conversation

@nschad

@nschad nschad commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

How to categorize this PR?

/kind task

What this PR does / why we need it:

TODO removed. Implementation was correct, added some more input

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

…rceType==backup is valid

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@ske-prow ske-prow Bot added the kind/task General task label Jul 20, 2026
@ske-prow

ske-prow Bot commented Jul 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign robinschneider for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2026
@nschad nschad changed the title chore: clarify TODO about setting encryption parameters for volumeSourceType==backup is valid chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid Jul 20, 2026
@nschad

nschad commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@stackit-ske

Copy link
Copy Markdown

@nschad: once the present PR merges, I will cherry-pick it on top of release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nschad nschad changed the title chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/task General task size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants