WIP: Upgrade to solid 2 beta by brenelz · Pull Request #2091 · solidjs/solid-start

brenelz · 2026-03-04T21:00:00Z

PR Checklist

Seeing what It take to update SolidStart to use Solid 2.0 beta. The examples work even with solid-router

netlify · 2026-03-04T21:00:06Z

✅ Deploy Preview for solid-start-landing-page ready!

Name	Link
🔨 Latest commit	`ab9a641`
🔍 Latest deploy log	https://app.netlify.com/projects/solid-start-landing-page/deploys/6a60e9493368d20008f89b65
😎 Deploy Preview	https://deploy-preview-2091--solid-start-landing-page.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

changeset-bot · 2026-03-04T21:00:08Z

🦋 Changeset detected

Latest commit: ab9a641

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@solidjs/start	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-03-04T21:00:49Z

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2091

commit: 712731b

lxsmnsyc · 2026-03-17T06:56:29Z

We can probably use ^2.0.0-beta.3 based on my tests

lxsmnsyc · 2026-03-21T15:58:51Z

needs rebasing

- Update leftover accessor-style children callbacks to beta.15 semantics: non-keyed <For> and keyed <Show> now pass raw values, not accessors (notes, hackernews, todomvc fixtures + one missed spot in the dev overlay) - Patch terracotta to shim removed @solidjs/web createDynamic export - Align @solidjs/signals in apps/tests with solid-js 2.0.0-beta.15 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts: # apps/tests/vite.config.ts # packages/start/package.json # packages/start/src/config/index.ts # packages/start/src/fns/handler.ts # packages/start/src/fns/server.ts # packages/start/src/server/handler.ts # pnpm-lock.yaml

- onSettled no longer accepts async callbacks (a returned Promise is an invalid cleanup value) — wrap the async work in a void IIFE across the test routes, and convert main's new server-env route from createEffect(async) to the same pattern - dev overlay: Errored's fallback now receives an accessor, and signal writes inside the boundary's owned scope throw — read the error and defer the push to a microtask Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

In Solid 2, createEffect's compute runs during SSR, so the export check executed on the server — where the "use server" module legitimately still exports testQuery — baking "true" into the markup. Use onSettled (a server no-op) like the other server-function routes so the check runs against the client module, where non-function exports are stripped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

terracotta next.6 migrated to solid 2.0.0-beta.15 (own createDynamic helper, JSX types from @solidjs/web), so the pnpm patch shimming the removed @solidjs/web createDynamic export is no longer needed, and the dev overlay's Select props no longer need the `as any` cast. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Bring back the withAssets logic in shared/lazy.ts (id$$ manifest lookup + useAssets injection with nonce), adapted to beta.15 where lazy() takes a required moduleUrl in SSR: - config/lazy.ts: inject vite-plugin-solid's __SOLID_LAZY_MODULE__ placeholder into user-land lazy() calls before rewriting the solid-js import, since the plugin only injects it for "solid-js" imports - server/handler.ts: resolve unknown moduleUrls in the dev manifest via a Proxy fallback so client hydration can preload lazy modules in dev - css fixture: replace removed createAsync with createMemo, pass an explicit moduleUrl for the import.meta.glob lazy, and fix onSettled returning a non-cleanup value Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The raw-HTML-string workaround existed for a babel-plugin-jsx-dom-expressions spread crash that's fixed in 0.50.0-next.14. The remaining blocker was beta.15's owner-based hydration keys: useAssets thunks run at shell-injection time with no owner, so ssrElement's getNextContextId call threw and killed the server process. Wrapping the asset JSX in <NoHydration> provides an owner with hydration-key generation disabled — correct for head tags, which never hydrate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Solid v2 renders the css already itself

Co-authored-by: Cursor <cursoragent@cursor.com>

The dom-expressions asset registry + vite-plugin-solid's virtual manifests now cover everything Start's custom plumbing did: - pass virtual:solid-manifest straight to renderToString/renderToStream (dev: async resolver collecting inline styles from the module graph; prod: the client build manifest), replacing getSsrManifest, collect-styles, and the per-request asset collection in createPageEvent - register entry-owned CSS at render start in dev (the resolver manifest can't be enumerated by the runtime) and inject vite-plugin-solid's devStylePatch for HMR adoption of streamed style tags - acquire/release route CSS on the client through virtual:solid-manifest/client + acquireAsset, keyed by route source, so navigations add stylesheets before paint and drop them on leave - use solid-js lazy directly; its moduleUrl transform, hydration-id keyed module map, and modulepreload registration replace Start's wrapper and the lazy() config transforms - delete the now-unused manifest/, assets/, collect-styles, shared/lazy modules and the capture-client-bundle plugin Co-authored-by: Cursor <cursoragent@cursor.com>

…ization protocol Deletes src/directives/* in favor of the serverFunctions() plugin hoisted into vite-plugin-solid (same compiler, plus root-relative function id hashing and a persisted client->SSR manifest for two-invocation builds). Ports fns/serialization.ts onto @solidjs/web/serialization: the default JSON codec now gets its plugin set, feature policy, and depth limit from the shared protocol layer, and the opt-in "js" (eval) mode shares the same plugin resolution. Files are annotated with a protocol/generic/ policy taxonomy to guide what hoists next. Co-authored-by: Cursor <cursoragent@cursor.com>

Start's fns layer is now configuration over the core runtime: the client re-exports the fetch transport (endpoint set from BASE_URL), the server configures event provisioning and endpoint over the core registry, and the HTTP handler is core handleServerFunctionRequest with Start's policies as hooks (single-flight collection, no-JS flash cookie). The bespoke registration/serialization/shared modules and the customBody shim are deleted — the router (0.17.0-next.5) consumes the core protocol directly. The eval-based SEROVAL_MODE option is dropped. Everything now resolves from the published stack: solid 2.0.0-beta.19, router 0.17.0-next.5, vite-plugin-solid 3.0.0-next.11 (local link overrides removed). Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

brenelz · 2026-07-20T18:46:57Z

+    esbuildOptions: {
+      plugins: [
+        {
+          name: "solid-compat",


this can probably be removed

Single-flight collection and the no-JS flash-cookie convention move to @solidjs/router (their vocabulary — query cache keys, submissions — is the router's). handleSingleFlight's data-only app render, transformResult, createSingleFlightHeaders, handleNoJS, and the flash-cookie SSR seeding are deleted; the handler wires createFlightDataCollector({ routes, base }) (the router's pure preload runner over the file-system route tree) and createNoJSHandler({ base }) from @solidjs/router/server into the core handler hooks. TEMPORARY workspace overrides link the sibling solid-router/solid checkouts until the releases carrying the flight bridge ship. Co-authored-by: Cursor <cursoragent@cursor.com>

Start's GET read the client proxy's .GET property, which the core extension surface removed (references now declare their method through GET(fn) over the metadata channel). The shim would silently return undefined; @solidjs/start now re-exports GET from @solidjs/web/server-functions so the import surface is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>

… 3.0.0-next.14 The published releases now carry the flight bridge and the router's server-function integration, so the TEMPORARY workspace links to the sibling solid/solid-router checkouts are removed in favor of pinned versions. Co-authored-by: Cursor <cursoragent@cursor.com>

…rror test Solid pins move to beta.22 across packages/start, apps/tests, and the fixtures; the minimumReleaseAge exclusions follow (babel-plugin-jsx to 0.50.0-next.25 via babel-preset-solid). vite-plugin-solid stays at 3.0.0-next.14. The runtime now percent-encodes non-latin1 messages on the X-Server-Function-Error header behind the =?1? marker with a symmetric client decoder, so the unicode error propagation test is unskipped and tightened to assert the message round-trips exactly. Co-authored-by: Cursor <cursoragent@cursor.com>

…tory The router 1.0 removes the component API, so @solidjs/start/router now exports the file-system route tree as a value — fileRoutes — instead of the FileRoutes component; apps pass it to createRouter({ routes }) and render the returned instance with their root layout as the render-prop child. Routes are immutable per instance, so one shared tree replaces the per-request build: PageEvent.routes is gone and the single-flight collector consumes fileRoutes directly. The tests app and fixtures move to the factory (rootPreload becomes the factory's preload option, <Navigate> becomes useNavigate during setup, <A> becomes plain anchors with active styling on the router's [data-active] attribute). Known blocker: client hydration fails against this router build because setupLinkClaims creates a client-only createRenderEffect under the id-carrying router owner, consuming a hydration child id the server never allocates — every subsequent id shifts and lazy route modules are not preloaded before hydration. 19 of 26 e2e tests fail on it; needs an upstream router fix (the claims effect must not consume hydration ids). Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Vite's bundledDev serves only bundled output filenames and provides no API to map a module id to its served URL, so Start's streamed-SSR preload/hydration hints emit URLs that 404 and hydration of code-split routes fails. Warn at dev-server startup instead of degrading silently, and drop the e2e:bundled-dev leg from test:all until Vite ships the module-URL API (vitejs/vite#22991). The script and its playwright config are kept for when it does. Co-authored-by: Cursor <cursoragent@cursor.com>

brenelz added 2 commits March 4, 2026 13:46

Initial upgrade to solid v2

05bf908

Fix hydration mismatch

a26c9b4

brenelz commented Mar 4, 2026

View reviewed changes

Comment thread packages/start/src/server/assets/index.ts Outdated

brenelz commented Mar 4, 2026

View reviewed changes

Comment thread packages/start/src/server/assets/render.tsx Outdated

brenelz commented Mar 4, 2026

View reviewed changes

Comment thread packages/start/package.json Outdated

brenelz added 7 commits March 4, 2026 20:44

fixes

984a368

dedupe solid and solid-router

1c0efad

fixture tweaks

de8272b

more hackernews tweaks

ad6c458

fixes

6d3a870

upgrade to newest solid beta

cc134c5

Reset landing page to v1 because of kobalte

57c529f

brenelz commented Mar 7, 2026

View reviewed changes

Comment thread packages/start/src/fns/handler.ts Outdated

brenelz commented Mar 7, 2026

View reviewed changes

Comment thread packages/start/src/shared/dev-overlay/DevOverlayDialog.tsx Outdated

lockfile changes

656cda1

lxsmnsyc reviewed Mar 9, 2026

View reviewed changes

Comment thread packages/start/package.json Outdated

brenelz added 4 commits March 10, 2026 09:17

use solidjs next version

91a89a8

ugprade to beta.2

3dc43fc

fix lockfile

39e4a8f

Upgrade to solid v2 beta.3

a7cf407

brenelz and others added 5 commits March 17, 2026 20:08

Update to latest solid meta

91720b4

Update router deps

b7a253d

Merge branch 'main' into upgrade-to-solid-2-beta

4c7cfc9

Fix tests

b6c3480

feat(2.0): terracotta@next (#2118)

a4e888d

brenelz and others added 6 commits July 3, 2026 14:15

update to solidjs beta.15

6a5107a

katywings reviewed Jul 8, 2026

View reviewed changes

Comment thread packages/start/src/shared/lazy.ts

brenelz commented Jul 8, 2026

View reviewed changes

Comment thread packages/start/src/server/handler.ts Outdated

brenelz and others added 13 commits July 8, 2026 10:25

update to solidjs beta.16

c597710

chore: bring back missing data deferStream in css fixture

6ed7d80

fix: disable all css handling

78557ff

Solid v2 renders the css already itself

update to solidjs beta.17

90cb9cd

update to solidjs beta.18 and vite-plugin-solid 3.0.0-next.9

5395db4

Co-authored-by: Cursor <cursoragent@cursor.com>

update to solidjs beta.20 and vite-plugin-solid 3.0.0-next.13

75a3203

Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'main' into upgrade-to-solid-2-beta

3622d02

test: skip unsupported Solid 2 server function cases

8bdca50

brenelz commented Jul 20, 2026

View reviewed changes

ryansolid and others added 8 commits July 20, 2026 14:20

chore(deps): bump @solidjs/router to 1.0.0-next.8

696db23

Co-authored-by: Cursor <cursoragent@cursor.com>

chore(deps): bump vite-plugin-solid to 3.0.0-next.15

b1342c9

Co-authored-by: Cursor <cursoragent@cursor.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP: Upgrade to solid 2 beta#2091

WIP: Upgrade to solid 2 beta#2091
brenelz wants to merge 50 commits into
mainfrom
upgrade-to-solid-2-beta

brenelz commented Mar 4, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lxsmnsyc commented Mar 17, 2026

Uh oh!

lxsmnsyc commented Mar 21, 2026

Uh oh!

Uh oh!

Uh oh!

brenelz Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

brenelz commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Uh oh!

netlify Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for solid-start-landing-page ready!

Uh oh!

changeset-bot Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lxsmnsyc commented Mar 17, 2026

Uh oh!

lxsmnsyc commented Mar 21, 2026

Uh oh!

Uh oh!

Uh oh!

brenelz Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

brenelz commented Mar 4, 2026 •

edited

Loading

netlify Bot commented Mar 4, 2026 •

edited

Loading

changeset-bot Bot commented Mar 4, 2026 •

edited

Loading

pkg-pr-new Bot commented Mar 4, 2026 •

edited

Loading