Skip to content

fix(media): validate upload paths before generation #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j15z wants to merge 10 commits into
base: staging
Choose a base branch
from
Open

fix(media): validate upload paths before generation #5615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1abcde7
fix(media): validate upload paths before generation
j15z Jul 12, 2026
ba6fe69
fix(media): preflight all writable outputs
j15z Jul 12, 2026
fe66099
fix(copilot): mount chat uploads in code sandboxes
j15z Jul 23, 2026
bb60a56
chore(copilot): refresh Mothership tool contracts
j15z Jul 23, 2026
3b10b73
refactor(media): clarify file cardinality helpers
j15z Jul 23, 2026
fc1f11e
fix(media): restore automatic ffmpeg output paths
j15z Jul 23, 2026
522855a
fix(media): restore automatic generated output paths
j15z Jul 23, 2026
bcf65d0
refactor(media): clarify validation ordering
j15z Jul 23, 2026
5ac760f
refactor(media): restore ffmpeg fallback expression
j15z Jul 23, 2026
3e1bdbc
Address PR review feedback (#5615)
j15z Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 44 additions & 17 deletions apps/sim/lib/copilot/generated/tool-catalog-v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,14 +1269,14 @@ export const Ffmpeg: ToolCatalogEntry = {
},
files: {
type: 'array',
description: 'Workspace files to mount into the sandbox.',
description: 'Workspace files or chat uploads to mount into the sandbox.',
items: {
type: 'object',
properties: {
path: {
type: 'string',
description:
'Canonical VFS file path, e.g. "files/Reports/sales.csv". By default this mounts at "/home/user/{path}".',
'Canonical VFS file path, e.g. "files/Reports/sales.csv" or "uploads/sales.csv". By default this mounts at "/home/user/{path}".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1286,6 +1286,7 @@ export const Ffmpeg: ToolCatalogEntry = {
},
required: ['path'],
},
minItems: 1,
},
tables: {
type: 'array',
Expand All @@ -1303,6 +1304,7 @@ export const Ffmpeg: ToolCatalogEntry = {
},
},
},
required: ['files'],
},
loopToVideo: {
type: 'boolean',
Expand Down Expand Up @@ -1358,7 +1360,8 @@ export const Ffmpeg: ToolCatalogEntry = {
},
path: {
type: 'string',
description: 'Canonical destination VFS path, e.g. "files/Reports/chart.png".',
description:
'Canonical destination VFS path under "files/", e.g. "files/Reports/chart.png".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1368,8 +1371,11 @@ export const Ffmpeg: ToolCatalogEntry = {
},
required: ['path', 'mode'],
},
minItems: 1,
maxItems: 1,
},
},
required: ['files'],
},
position: {
type: 'string',
Expand Down Expand Up @@ -1450,14 +1456,14 @@ export const FunctionExecute: ToolCatalogEntry = {
},
files: {
type: 'array',
description: 'Workspace files to mount into the sandbox.',
description: 'Workspace files or chat uploads to mount into the sandbox.',
items: {
type: 'object',
properties: {
path: {
type: 'string',
description:
'Canonical VFS file path, e.g. "files/Reports/sales.csv". By default this mounts at "/home/user/{path}".',
'Canonical VFS file path, e.g. "files/Reports/sales.csv" or "uploads/sales.csv". By default this mounts at "/home/user/{path}".',
},
sandboxPath: {
type: 'string',
Expand Down Expand Up @@ -1523,7 +1529,8 @@ export const FunctionExecute: ToolCatalogEntry = {
},
path: {
type: 'string',
description: 'Canonical destination VFS path, e.g. "files/Reports/chart.png".',
description:
'Canonical destination VFS path under "files/", e.g. "files/Reports/chart.png".',
},
sandboxPath: {
type: 'string',
Expand Down Expand Up @@ -1617,14 +1624,14 @@ export const GenerateAudio: ToolCatalogEntry = {
},
files: {
type: 'array',
description: 'Workspace files to mount into the sandbox.',
description: 'Workspace files or chat uploads to mount into the sandbox.',
items: {
type: 'object',
properties: {
path: {
type: 'string',
description:
'Canonical VFS file path, e.g. "files/Reports/sales.csv". By default this mounts at "/home/user/{path}".',
'Canonical VFS file path, e.g. "files/Reports/sales.csv" or "uploads/sales.csv". By default this mounts at "/home/user/{path}".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1634,6 +1641,8 @@ export const GenerateAudio: ToolCatalogEntry = {
},
required: ['path'],
},
minItems: 1,
maxItems: 1,
},
tables: {
type: 'array',
Expand All @@ -1651,6 +1660,7 @@ export const GenerateAudio: ToolCatalogEntry = {
},
},
},
required: ['files'],
},
instrumental: {
type: 'boolean',
Expand Down Expand Up @@ -1695,7 +1705,8 @@ export const GenerateAudio: ToolCatalogEntry = {
},
path: {
type: 'string',
description: 'Canonical destination VFS path, e.g. "files/Reports/chart.png".',
description:
'Canonical destination VFS path under "files/", e.g. "files/Reports/chart.png".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1705,8 +1716,11 @@ export const GenerateAudio: ToolCatalogEntry = {
},
required: ['path', 'mode'],
},
minItems: 1,
maxItems: 1,
},
},
required: ['files'],
},
prompt: {
type: 'string',
Expand Down Expand Up @@ -1767,14 +1781,14 @@ export const GenerateImage: ToolCatalogEntry = {
},
files: {
type: 'array',
description: 'Workspace files to mount into the sandbox.',
description: 'Workspace files or chat uploads to mount into the sandbox.',
items: {
type: 'object',
properties: {
path: {
type: 'string',
description:
'Canonical VFS file path, e.g. "files/Reports/sales.csv". By default this mounts at "/home/user/{path}".',
'Canonical VFS file path, e.g. "files/Reports/sales.csv" or "uploads/sales.csv". By default this mounts at "/home/user/{path}".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1784,6 +1798,7 @@ export const GenerateImage: ToolCatalogEntry = {
},
required: ['path'],
},
minItems: 1,
},
tables: {
type: 'array',
Expand All @@ -1801,6 +1816,7 @@ export const GenerateImage: ToolCatalogEntry = {
},
},
},
required: ['files'],
},
outputs: {
type: 'object',
Expand Down Expand Up @@ -1830,7 +1846,8 @@ export const GenerateImage: ToolCatalogEntry = {
},
path: {
type: 'string',
description: 'Canonical destination VFS path, e.g. "files/Reports/chart.png".',
description:
'Canonical destination VFS path under "files/", e.g. "files/Reports/chart.png".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1840,8 +1857,11 @@ export const GenerateImage: ToolCatalogEntry = {
},
required: ['path', 'mode'],
},
minItems: 1,
maxItems: 1,
},
},
required: ['files'],
},
prompt: {
type: 'string',
Expand Down Expand Up @@ -1905,14 +1925,14 @@ export const GenerateVideo: ToolCatalogEntry = {
},
files: {
type: 'array',
description: 'Workspace files to mount into the sandbox.',
description: 'Workspace files or chat uploads to mount into the sandbox.',
items: {
type: 'object',
properties: {
path: {
type: 'string',
description:
'Canonical VFS file path, e.g. "files/Reports/sales.csv". By default this mounts at "/home/user/{path}".',
'Canonical VFS file path, e.g. "files/Reports/sales.csv" or "uploads/sales.csv". By default this mounts at "/home/user/{path}".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1922,6 +1942,8 @@ export const GenerateVideo: ToolCatalogEntry = {
},
required: ['path'],
},
minItems: 1,
maxItems: 1,
},
tables: {
type: 'array',
Expand All @@ -1939,6 +1961,7 @@ export const GenerateVideo: ToolCatalogEntry = {
},
},
},
required: ['files'],
},
model: {
type: 'string',
Expand Down Expand Up @@ -1989,7 +2012,8 @@ export const GenerateVideo: ToolCatalogEntry = {
},
path: {
type: 'string',
description: 'Canonical destination VFS path, e.g. "files/Reports/chart.png".',
description:
'Canonical destination VFS path under "files/", e.g. "files/Reports/chart.png".',
},
sandboxPath: {
type: 'string',
Expand All @@ -1999,8 +2023,11 @@ export const GenerateVideo: ToolCatalogEntry = {
},
required: ['path', 'mode'],
},
minItems: 1,
maxItems: 1,
},
},
required: ['files'],
},
prompt: {
type: 'string',
Expand Down Expand Up @@ -3424,14 +3451,14 @@ export const RunCode: ToolCatalogEntry = {
},
files: {
type: 'array',
description: 'Workspace files to mount into the sandbox.',
description: 'Workspace files or chat uploads to mount into the sandbox.',
items: {
type: 'object',
properties: {
path: {
type: 'string',
description:
'Canonical VFS file path, e.g. "files/Reports/sales.csv". By default this mounts at "/home/user/{path}".',
'Canonical VFS file path, e.g. "files/Reports/sales.csv" or "uploads/sales.csv". By default this mounts at "/home/user/{path}".',
},
sandboxPath: {
type: 'string',
Expand Down
Loading
Loading