Introduce raise_on_unhandled_modal browser configuration#320
Open
seanpdoyle wants to merge 1 commit into
Open
Conversation
seanpdoyle
force-pushed
the
raise_on_unhandled_modal
branch
3 times, most recently
from
July 23, 2026 18:54
c6b499d to
95bff0e
Compare
The problem --- When executing a system test suite that relies on `confirm`, `prompt`, or other browser-level modals, the default behavior to ignore modally presented dialogs can cause false negatives. For example, a change to the implementation might accidentally introduce a perpetually prompting confirmation modal. While the test suite outputs "Modal window … has been opened" warnings, the underlying test still passes. The proposal --- This commit proposes a new Cuprite-level `:raise_on_unhandled_modal` option to control whether an unhandled modal warns, or raises. When set to `true`, then false negative test would fail, rather than pass.
seanpdoyle
force-pushed
the
raise_on_unhandled_modal
branch
from
July 23, 2026 19:21
95bff0e to
1692d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
When executing a system test suite that relies on
confirm,prompt, or other browser-level modals, the default behavior to ignore modally presented dialogs can cause false negatives.For example, a change to the implementation might accidentally introduce a perpetually prompting confirmation modal. While the test suite outputs "Modal window … has been opened" warnings, the underlying test still passes.
The proposal
This commit proposes a new Cuprite-level
:raise_on_unhandled_modaloption to control whether an unhandled modal warns, or raises. When set totrue, then false negative test would fail, rather than pass.