Skip to content

fix(android): use the active locale to detect RTL direction #57635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zoontek wants to merge 2 commits into from
+7 −9
Closed

fix(android): use the active locale to detect RTL direction #57635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86b0017
fix(android): use the active locale to detect RTL direction
zoontek Jul 22, 2026
0262581
Run ktmft
zoontek Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions ...eact-native/ReactAndroid/src/main/java/com/facebook/react/modules/i18nmanager/I18nUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import android.content.Context
import android.content.pm.ApplicationInfo
import android.view.View
import androidx.core.text.TextUtilsCompat
import java.util.Locale

public class I18nUtil private constructor() {
/**
Expand All @@ -21,7 +20,7 @@ public class I18nUtil private constructor() {
*/
public fun isRTL(context: Context): Boolean =
applicationHasRtlSupport(context) &&
(isRTLForced(context) || (isRTLAllowed(context) && isDevicePreferredLanguageRTL))
(isRTLForced(context) || (isRTLAllowed(context) && isDevicePreferredLanguageRTL(context)))

/**
* Android relies on the presence of `android:supportsRtl="true"` being set in order to resolve
Expand Down Expand Up @@ -60,13 +59,12 @@ public class I18nUtil private constructor() {
setPref(context, KEY_FOR_PREFS_FORCERTL, forceRTL)
}

private val isDevicePreferredLanguageRTL: Boolean
// Check if the current device language is RTL
get() {
val directionality =
TextUtilsCompat.getLayoutDirectionFromLocale(Locale.getAvailableLocales()[0])
return directionality == View.LAYOUT_DIRECTION_RTL
}
// Check if the current device language is RTL
private fun isDevicePreferredLanguageRTL(context: Context): Boolean {
val directionality =
TextUtilsCompat.getLayoutDirectionFromLocale(context.resources.configuration.locales[0])
return directionality == View.LAYOUT_DIRECTION_RTL
}

private fun isPrefSet(context: Context, key: String, defaultValue: Boolean): Boolean =
context
Expand Down
Loading