-
Notifications
You must be signed in to change notification settings - Fork 25.2k
feat: migrate to SceneDelegate #53744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artus9033
wants to merge
69
commits into
react:main
Choose a base branch
from
artus9033:feat/scene-delegate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
917f539
feat: migrate to SceneDelegate, update RNTester code
artus9033 8b4adc0
feat: provide two configurations for launching RNTester based on Scen…
artus9033 2863c4c
feat: migrate RNTester NativeExampleViews to support SceneDelegate
artus9033 d27e491
chore: remove obsolete code
artus9033 0ac5467
chore: updated Podfile.lock
artus9033 0232d98
chore: revert unnecessary migration in RCTDeviceInfo
artus9033 a81e935
fix: migrate usages of application.delegate.window to use RCTKeyWindo…
artus9033 6a0dce2
feat: add NativeDeviceInfo.getInfo, deprecate NativeDeviceInfo.getCon…
artus9033 641a29c
test: test if getInfo works and has Dimensions property
artus9033 d961af6
feat: added imperative non-subscription demos to DimensionsExample in…
artus9033 dc7763c
feat: stub for DeviceInfoModule.getInfo CXX implementation
artus9033 c0bc778
fix: RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD RCTDeviceInfo.getInfo
artus9033 c77f68a
fix(test): fix integration tests js app problems due to ES exports
artus9033 1e7a30e
fix(test): fix unit tests compilation errors
artus9033 5448f10
fix: ensure that RCTDeviceInfo::invalidateCachedInfo logic is run on …
artus9033 7eebb2f
fix(test): add jest mock for JS DeviceInfo.getInfo
artus9033 1f25576
fix(test): fix AccessibilityManagerTest failing because of handling l…
artus9033 d436cd8
refactor: explicitly depend on retained self in RCTExecuteOnMainQueue…
artus9033 75d2c66
refactor: typo in TODO comment in RCTDeviceInfo
artus9033 5045ad8
test: disable AccessibilityManagerTest due to T225745315
artus9033 cb9a5b4
docs: update unit and integration tests instructions
artus9033 697758b
Merge branch 'main' into artur/feat/scene-delegate
artus9033 b37bcd9
chore: update Podfile.lock
artus9033 de29fca
Revert "fix: RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD RCTDeviceInfo.get…
artus9033 2ed5739
Revert "feat: stub for DeviceInfoModule.getInfo CXX implementation"
artus9033 4ede7e8
Revert "fix(test): add jest mock for JS DeviceInfo.getInfo"
artus9033 7bc2b30
Revert "feat: add NativeDeviceInfo.getInfo, deprecate NativeDeviceInf…
artus9033 d3c2cd4
feat: invalidate cached value of dimensions for internal state consis…
artus9033 7db2384
chore: updated RNTester Podfile, integration tests xcscheme and pbxproj
artus9033 a4503ab
feat: deprecate getConstants in NativeDeviceInfo, introduce getInfo a…
artus9033 8771ff1
chore: update Podfile
artus9033 4268e4c
Merge branch 'main' into artur/feat/scene-delegate
artus9033 785f869
refactor: sort imports in DimensionsExample
artus9033 e332eb7
feat: added NativeDeviceInfo.getInfo API to RN API snapshot
artus9033 c69f974
fix: typechecking in IntegrationTestsApp.js
artus9033 3b0416b
feat: warn at runtime from RCTReactNativeFactory if unsupported capab…
artus9033 543c296
chore: update Podfile.lock
artus9033 6f5935a
Merge branch 'main' into artur/feat/scene-delegate
artus9033 3f96863
Merge branch 'main' into artur/feat/scene-delegate
artus9033 a72e1e3
wip: PoC fixing delayed application of ShadowTree commits after inten…
artus9033 f661e41
Merge remote-tracking branch 'facebook/main' into artur/feat/scene-de…
artus9033 5aac7cd
chore: retract the workarounds
artus9033 1c0c5ad
Merge branch 'main' into feat/scene-delegate
artus9033 2d64c04
chore: update ReactNativeApi.d.ts SignedSource
artus9033 ea3c55e
chore: use RCTLogWarn in RCTReactNativeFactory if running with multiw…
artus9033 693b31d
feat: support RCTDevLoadingView resizing
artus9033 b822bec
fix: print warning of unsupported configuration from hostDidStart to …
artus9033 d751f4c
Merge branch 'main' into feat/scene-delegate
artus9033 041c9bc
chore: remove new NativeDeviceInfo API
artus9033 a75ed5b
chore: update project.pbxproj
artus9033 37cfa12
feat: support resizing in RCTDevLoadingView using automatic constrain…
artus9033 dbad6af
Merge branch 'main' into feat/scene-delegate
artus9033 d874dda
feat: add RCTSceneDelegate for UIScene-based iOS app bootstrap
artus9033 a0b8944
feat: migrate RNTester and HelloWorld to RCTSceneDelegate
artus9033 0820933
Merge branch 'main' into feat/scene-delegate
artus9033 d5a5a6d
fix: helloworld text to be visible in dark mode, missing Gems in hell…
artus9033 0979697
fix: RCTAppDelegate to depend on RCTLinking
artus9033 78f298c
fix(types): comply with Flow linter
artus9033 49816a3
chore: commit cxx API files
artus9033 bdf5a0a
feat: assert that the users do not enable multiple scenes
artus9033 48d6172
chore: deintegrate RCTSceneDelegate after CR
artus9033 46e9ee9
chore: remove RCT_REMOVE_LEGACY_ARCH conditionals as it is not possib…
artus9033 5241090
refactor: do not use inverted logic in RCTLinkingManager
artus9033 6fa4f4b
Revert "fix(test): fix integration tests js app problems due to ES ex…
artus9033 d4cab37
chore: drop AppDelegate support in RNTester
artus9033 d09a548
chore: deintegrate legacy AppDelegate from helloworld
artus9033 5453a82
Merge branch 'main' into feat/scene-delegate
cipolleschi 6409517
Merge branch 'main' into feat/scene-delegate
cipolleschi 6380d24
chore: regenerate CXX API definitions
artus9033 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.