gh-154525: Skip ncurses find_pair()/alloc_pair() reuse checks before 6.3#154543
Merged
serhiy-storchaka merged 1 commit intoJul 23, 2026
Merged
Conversation
…efore 6.3 find_pair() and reuse in alloc_pair() were fixed in ncurses 6.3 (patch 20200411). On earlier versions find_pair() returns -1 and alloc_pair() allocates a fresh pair instead of reusing an equal one, so test_dynamic_color_pairs failed on ncurses 6.1 and 6.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
enabled auto-merge (squash)
July 23, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_pair()and pair reuse inalloc_pair()were fixed in ncurses 6.3 (patch 20200411). On earlier versionsfind_pair()returns -1 andalloc_pair()allocates a fresh pair instead of reusing an equal one, sotest_dynamic_color_pairsfailed on ncurses 6.1 and 6.2.Gate the reuse and find assertions on
ncurses_version >= (6, 3); older versions still exercisefree_pair().Verified on ncursesw 6.1 (previously failing) and 6.6.
Follow-up of #154526.