gh-154335: Allow disabling terminal colors in Tachyon's pstats_collector module

[pfackeldey]

This PR uses _colorize.get_colors() instead of the _colorize.ANSIColors enum. That way, one can disable terminal coloring through ANSI escape codes with e.g. setting certain env vars, such as NO_COLOR=1.

I couldn't find an appropriate place for a test (and also I wasn't sure what's the best way to test this). Please let me know what your preference is regarding a test, and I'm happy to add it.

• Issue: Tachyon's pstats_collector does not respect "no-color" modes #154335

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[edvilme]

Maybe this could be extended to include Lib/profiling/sampling/sample.py as well?

[pfackeldey]

Maybe this could be extended to include Lib/profiling/sampling/sample.py as well?

Good point, I missed this one. I'll update the PR asap 👍

[pfackeldey]

Dear @pablogsal and @edvilme,
do you have by chance an idea how to deal with the failing test case for iOS and Android?

It seems that for iOS and Android the coloring changes somehow the behavior of this test, likely here, but I don't fully understand it yet, and I'm not sure how I can reproduce the failure for debugging locally.

I found the fix! the no-color path (on iOS and Android) will not skip the header line of the pstats output in the test case, which it should though to populate data_lines correctly. The following patch fixes it:

diff --git a/Lib/test/test_profiling/test_sampling_profiler/test_profiler.py b/Lib/test/test_profiling/test_sampling_profiler/test_profiler.py
index 2f5a5e27328..6b999e04e3d 100644
--- a/Lib/test/test_profiling/test_sampling_profiler/test_profiler.py
+++ b/Lib/test/test_profiling/test_sampling_profiler/test_profiler.py
@@ -751,6 +751,7 @@ def test_print_sampled_stats_sort_by_name(self):
                 and not "calls" in line  # Skip summary lines
                 and not "total time" in line  # Skip summary lines
                 and not "cumulative time" in line
+                and not "filename:lineno(function)" in line  # Skip header line
             ):  # Skip summary lines
                 data_lines.append(line)

I'm happy to add this if you agree that this is the correct approach.

Let me know what you think, Peter