Fix QoiDecoder crash on truncated QOI files#9813
Open
abhi-0203 wants to merge 1 commit into
Open
Conversation
Check for empty reads before indexing in QoiDecoder.decode() to prevent IndexError when a truncated QOI file is opened. The decoder now raises OSError with 'image file is truncated' message, consistent with other Pillow decoders. Fixes python-pillow#9812
Member
|
I've created abhi-0203#1 with a suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
QoiDecoder.decode()when a truncated QOI file is opened. The decoder now raisesOSErrorwith the standard "image file is truncated" message instead of an uncaughtIndexError.Problem
When a truncated QOI file is opened,
QoiDecoder.decode()reads past EOF and indexes the empty result ofread(1), causing anIndexError:This affects multiple read sites in the decoder:
Fix
Added length checks before indexing all
read()results. When a short read is detected (EOF), the decoder raisesOSError("image file is truncated"), consistent with other Pillow decoders (JPEG, PNG, etc.).Testing
The fix can be verified by opening a truncated QOI file:
Fixes #9812