Skip to content

chore(Slider): Include OUIAProps for Slider#12585

Open
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:slider-ouia
Open

chore(Slider): Include OUIAProps for Slider#12585
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:slider-ouia

Conversation

@mshriver

@mshriver mshriver commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Add OUIA attribute support to Slider for better test automation.

What:
Closes #12584

Summary by CodeRabbit

  • New Features

    • Added OUIA support to the Slider component, including configurable component IDs and safety attributes.
    • Slider components now expose standardized identification and accessibility metadata.
  • Documentation

    • Added Slider to the documented OUIA-supported component list.

Add OUIA attribute support to Slider for better test automation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ecdef91-8bed-40d6-a946-9bdd88da4c4a

📥 Commits

Reviewing files that changed from the base of the PR and between 7a55868 and d9750a7.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/Slider/__tests__/__snapshots__/Slider.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • packages/react-core/src/components/Slider/Slider.tsx
  • packages/react-core/src/components/Slider/__tests__/Slider.test.tsx
  • packages/react-core/src/helpers/OUIA/OUIA.md

Walkthrough

Slider now supports OUIA properties, applies generated data-ouia-* attributes to its root element, tests default and custom values, and includes Slider in the OUIA component documentation.

Changes

Slider OUIA integration

Layer / File(s) Summary
OUIA contract and root wiring
packages/react-core/src/components/Slider/Slider.tsx
SliderProps accepts ouiaId and ouiaSafe; Slider generates OUIA attributes and applies them to the root element.
OUIA validation and documentation
packages/react-core/src/components/Slider/__tests__/Slider.test.tsx, packages/react-core/src/helpers/OUIA/OUIA.md
Tests verify OUIA IDs, component type, and safe-mode attributes, and documentation lists Slider support.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Consumer
  participant Slider
  participant useOUIAProps
  participant SliderRoot
  Consumer->>Slider: provide ouiaId and ouiaSafe
  Slider->>useOUIAProps: generate OUIA attributes
  useOUIAProps-->>Slider: return ouiaProps
  Slider->>SliderRoot: spread ouiaProps
Loading

Possibly related PRs

Suggested reviewers: rebeccaalpert, thatblindgeye

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: adding OUIA props support to Slider.
Linked Issues check ✅ Passed Slider now supports OUIA props and tests confirm the expected data attributes.
Out of Scope Changes check ✅ Passed The docs and test updates are directly related to the Slider OUIA support change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider missing OUIA Support

2 participants