feat: Add acknowledgeFutureDefaults option to suppress future default deprecation warnings#10599
feat: Add acknowledgeFutureDefaults option to suppress future default deprecation warnings#10599anaghroy wants to merge 1 commit into
Conversation
… deprecation warnings
|
I will reformat the title to use the proper commit message syntax. |
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds the ChangesFuture default acknowledgement
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.3)src/Options/index.jsFile contains syntax errors that prevent linting: Line 18: Expected a type but instead found '?'.; Line 18: Expected a property, or a signature but instead found ';'.; Line 21: Expected a statement but instead found '?'.; Line 24: Expected a statement but instead found '?'.; Line 27: Expected a statement but instead found '?'.; Line 30: Expected a statement but instead found '?'.; Line 32: Expected a statement but instead found '?'.; Line 34: Expected a statement but instead found '?'.; Line 35: Expected a statement but instead found '}'.; Line 37: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 38: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 39: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 40: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Li ... [truncated 16813 characters] ... found '?'.; Line 916: Expected a statement but instead found '?'.; Line 918: Expected a statement but instead found '?'.; Line 919: Expected a statement but instead found '}'.; Line 933: Expected a type but instead found '?'.; Line 933: Expected a property, or a signature but instead found ';'.; Line 934: Expected a statement but instead found '}'.; Line 940: Expected a type but instead found '?'.; Line 940: Expected a property, or a signature but instead found ';'.; Line 944: Expected a statement but instead found '?'.; Line 948: Expected a statement but instead found '?'.; Line 952: Expected a statement but instead found '?'.; Line 956: Expected a statement but instead found '?'.; Line 960: Expected a statement but instead found '?'.; Line 961: Expected a statement but instead found '}'. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request
Issue
Closes #10584
Approach
Developers requested a clean way to suppress
DeprecationWarnings that only relate to future default changes without completely silencing all deprecation warnings globally.This PR introduces a new boolean server option:
acknowledgeFutureDefaults.true,Deprecator.jssuppresses warnings thrown specifically forchangeNewDefault.src/Options/index.jsand regenerated inDefinitions.js.spec/Deprecator.spec.jsto ensure warnings are completely suppressed when the flag is enabled.Tasks
Summary by CodeRabbit
New Features
acknowledgeFutureDefaultsconfiguration option to suppress warnings about options with upcoming default-value changes.PARSE_SERVER_ACKNOWLEDGE_FUTURE_DEFAULTSenvironment variable.Bug Fixes
Documentation