fix(ui): remove redundant inner Description card on Domain & Data Product docs#30338
fix(ui): remove redundant inner Description card on Domain & Data Product docs#30338siddhant1 wants to merge 1 commit into
Conversation
…ct docs The Documentation tab on Domain and Data Product detail pages rendered the Description inside two nested cards - the standard left-panel frame and the Description's own wrapInCard box - producing a double border and an uneven bottom gap. Both pages place the Description as the sole child of the left panel, so the inner card just duplicates the frame. Add an optional wrapDescriptionInCard prop to CommonWidgets (default true, so every other entity type is unchanged) and pass false from the Domain and Data Product widget dispatchers. The Description now sits flush inside the single left-panel frame with even padding. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedRemoves the redundant nested card wrapper from Domain and Data Product documentation panels by introducing a conditional prop in CommonWidgets. This creates a clean, flush layout without affecting other entity types. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
siddhant1
added
UI
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Jest test CoverageUI tests summary
|
|
What
On the Documentation tab of Domain and Data Product detail pages, the Description now renders as a single, clean card — the header and text sit flush inside the standard left‑panel frame with even padding.
Previously the Description was wrapped in two nested cards: the standard left‑panel frame and the Description's own
wrapInCardbox (its own border + shadow + 18px padding). Because both of these pages place the Description as the sole child of the left panel, that inner card simply duplicated the frame — producing a double border and an uneven gap at the bottom.How
wrapDescriptionInCardprop toCommonWidgets(defaults totrue, so every other entity type is unchanged).getDomainWidgetsFromKey,getDataProductWidgetsFromKey) now passwrapDescriptionInCard={false}.Tables / dashboards / etc. keep their inner Description card — their left panel legitimately wraps multiple sections (Description and Schema) — so this change is scoped strictly to Domain + Data Product.
Before / After
Domain
Data Product
Testing
border: 1px / box-shadow / padding: 18px(inner card) toborder: 0 / no shadow / padding: 0(flush inside the frame).Descriptionand don't assert onwrapInCard, so they are unaffected.🤖 Generated with Claude Code
Greptile Summary
This PR removes the redundant inner Description card on Domain and Data Product documentation pages. The main changes are:
CommonWidgets.Confidence Score: 5/5
The default layouts look safe, with a non-blocking visual regression possible in customized layouts.
DomainUtils.tsx and DataProductUtils.tsx
Important Files Changed
Reviews (1): Last reviewed commit: "fix(ui): drop redundant inner Descriptio..." | Re-trigger Greptile
Context used (3)