ffi: validate fast i32 argument ranges#64691
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Add i32 and int32 to Fast API integer validation so optimized calls reject invalid values instead of allowing V8 to truncate them. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol
trivikr
force-pushed
the
ffi-i32-bypass-validation
branch
from
July 23, 2026 06:58
5cfc0ae to
a5ff09c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64691 +/- ##
==========================================
- Coverage 90.14% 90.14% -0.01%
==========================================
Files 741 741
Lines 242112 242114 +2
Branches 45605 45602 -3
==========================================
- Hits 218244 218243 -1
+ Misses 15360 15359 -1
- Partials 8508 8512 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64690
V8’s Fast API converts signed integer arguments to
int32bytruncation. Fast FFI signatures using
i32orint32did not enable theJavaScript integer-validation wrapper, so optimized calls could accept
out-of-range or non-integer values that the generic FFI path rejects.
Add both signed 32-bit type names to the Fast API validation metadata and
native validation-selection check.
Assisted-by: openai:gpt-5.6-sol