fs: support Buffer paths in cp methods#64686
Open
StealthEyeLLC wants to merge 1 commit into
Open
Conversation
Use byte-preserving path helpers for recursive copies. Read directory entries as buffers and retain Buffer paths where string conversion would lose data. Keep the existing string behavior when paths can be represented without losing information. Fixes: nodejs#58634 Signed-off-by: Jamie Currier <odinsravenxx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #58634
fs.cp(), fs.promises.cp(), and fs.cpSync() accept path-like arguments, but the recursive copy implementation used string-only path operations and decoded directory entry names as UTF-8. As a result, Buffer paths failed during recursive copies and non-UTF-8 file names could not be preserved.
This change adds internal path helpers that operate on strings and Buffers. Recursive directory traversal reads entry names with encoding: 'buffer' and retains Buffer paths where conversion to a string would lose information.
The existing cpSync() native fast path is still used when both paths are strings and no filter is present. Buffer paths use the JavaScript traversal.
Filter callback arguments remain strings for string and file URL inputs when the paths can be represented as strings. Buffer arguments are used when the corresponding paths need to remain byte-preserving. The fs documentation has been updated accordingly.
Tests cover:
The previous known-issue tests for these cases have been removed because the cases now pass.
Validation: