client: add Kubernetes-aware retry helpers#2634
Conversation
|
Welcome @sttts! |
ee00eac to
ec56a76
Compare
|
/assign @yliaog |
ec56a76 to
50d8aed
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
50d8aed to
3e89602
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
|
Fixed in the latest push: I also verified |
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
|
Addressed the latest AIO naming review feedback in cd96f0e. The public AIO retry helpers now use the same names as the sync helpers under the
The generated AIO wiring follow-up in kubernetes-client/gen#304 was updated as well. |
|
thanks for the PR |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5583fb5
into
kubernetes-client:master
Summary
Add client-go-style retry helper APIs for the sync and AIO Python clients.
kubernetes/base/retry.py.kubernetes.utils.retry.kubernetes.aio.utils.retry.setup-asyncio.pyand the combinedsetup-release.pypackage list.The generated REST/Configuration wiring is intentionally separate and follows in kubernetes-client/gen#304.
Validation
.venv/bin/python -m unittest kubernetes.utils.retry_test kubernetes.aio.utils.retry_test.venv/bin/python -m pytest -q kubernetes/utils/retry_test.py kubernetes/aio/utils/retry_test.py.venv/bin/python -m pycodestyle ...for retry helpers, exports, andsetup-release.pysetup.py,setup-asyncio.py, andsetup-release.pybuild_pychecks confirmed symlinked helper files are copied as regular filesgit diff --check