Skip to content

Add telemetry support to browser-pools CLI commands#205

Merged
Sayan- merged 3 commits into
mainfrom
hypeship/cli-pool-telemetry
Jul 21, 2026
Merged

Add telemetry support to browser-pools CLI commands#205
Sayan- merged 3 commits into
mainfrom
hypeship/cli-pool-telemetry

Conversation

@Sayan-

@Sayan- Sayan- commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Brings the CLI to parity with the API/SDK browser-pool telemetry surface (shipped in kernel-go-sdk v0.79.0).

What changed

  • kernel browser-pools create --telemetry=all|off|<categories> sets the telemetry applied to browsers warmed into the pool.
  • kernel browser-pools update --telemetry=... updates pool telemetry. Only applies to browsers warmed after the update.
  • kernel browser-pools acquire --telemetry=... sets a per-lease override, merged onto the pool config.
  • kernel browser-pools get now shows the pool's active telemetry in the details table.
  • kernel browsers create --pool-id/--pool-name --telemetry=... now accepts --telemetry as a per-lease flag and forwards it as an acquire override. Previously it was treated as a conflicting config flag and dropped.
  • Bumps kernel-go-sdk to v0.79.0.

Pool and browser --telemetry share the same parsing (all / off / comma-separated categories), so they behave identically.

Testing

Built bin/kernel off this branch and exercised each new path end-to-end:

Scenario Result
browser-pools create --telemetry=console,network stored config = console, network + operational set
browser-pools get new Telemetry row renders the active categories
browser-pools update --telemetry=all / =off resets to default set / disables; confirmed via get
browser-pools acquire --telemetry=page override reaches the leased browser
browsers create --pool-name … --telemetry=console forwarded as an acquire override (previously dropped)
invalid --telemetry on create/update/acquire rejected before the API call, nothing created or leased


Note

Low Risk
CLI-only feature parity with the SDK; validation runs before API calls and behavior mirrors existing browser telemetry flags.

Overview
Adds --telemetry to browser pool create, update, and acquire, aligned with single-browser telemetry (all / off / category lists) via a shared resolveTelemetryFlag helper and SDK v0.79.0.

Pool create/update send telemetry on warmed browsers; update only affects browsers warmed after the change. Acquire (and browsers create --pool-id|--pool-name) can pass a per-lease override merged onto the pool config—--telemetry is now allowed on the pool lease path instead of being treated as a conflicting flag. browser-pools get shows a Telemetry row; create/update print printTelemetrySummary when the flag is set.

README documents the new flags. Tests cover pool telemetry params, acquire forwarding, and invalid categories.

Reviewed by Cursor Bugbot for commit 0e54cb3. Bugbot is set up for automated code reviews on this repo. Configure here.

Bring the CLI to parity with the API/SDK telemetry surface for browser
pools: --telemetry on browser-pools create/update/acquire, display the
active config in browser-pools get, and forward --telemetry as an
acquire override on browsers create --pool-id/--pool-name.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@socket-security

socket-security Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​kernel/​kernel-go-sdk@​v0.78.0 ⏵ v0.79.072 +1100100100100

View full report

Replace five near-identical all/off/categories switches (browser
create/update + pool create/update/acquire) with a single
resolveTelemetryFlag resolver and thin per-endpoint adapters, so the
--telemetry flag grammar has one source of truth.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Sayan-
Sayan- requested a review from archandatta July 21, 2026 16:05
@Sayan-
Sayan- marked this pull request as ready for review July 21, 2026 16:05
@Sayan-
Sayan- requested review from archandatta and tnsardesai and removed request for archandatta July 21, 2026 16:05

@archandatta archandatta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Sayan-
Sayan- merged commit 2721fa8 into main Jul 21, 2026
7 checks passed
@Sayan-
Sayan- deleted the hypeship/cli-pool-telemetry branch July 21, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants