Fix bad state on unmap failure#1675
Merged
ludfjig merged 1 commit intoJul 22, 2026
Merged
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
July 21, 2026 21:36
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an error-path state consistency issue in HyperlightVm::unmap_region: if the hypervisor unmap operation fails, the VM should not forget the region or free the slot. The change keeps mmap_regions and freed_slots consistent with the actual hypervisor mapping state.
Changes:
- Unmap the memory region in the hypervisor before removing it from
mmap_regions. - Only return the slot to
freed_slotsafter a successful unmap.
ludfjig
changed the title
jsturtevant
reviewed
Jul 22, 2026
jsturtevant
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a potential issue where state gets messed up if the hv unmap fails, but we still mark it as removed. Fixed by unmapping first, and only then mark removed