fix(slack): sanitize generated session IDs#6437
Open
anneheartrecord wants to merge 3 commits into
Open
Conversation
Collaborator
|
Hi @sasha-gitg , can you please review this. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
SlackRunner builds ADK session IDs from Slack channel/thread identifiers. Slack timestamps include
., for exampleC0BARCEJJ1K-1784622590.251599, but managed session services validate session IDs against^[A-Za-z0-9_-]+$.Solution:
Sanitize Slack-derived session ID parts before passing them to
Runner.run_async, replacing characters outside the managed-session-safe set with_. Slack API calls still use the original Slackthread_ts, so Slack threading behavior is unchanged.Testing Plan
Unit Tests:
Passed locally:
uv run --with pytest --with pytest-asyncio --with slack-bolt --with aiohttp pytest tests/unittests/integrations/slack/test_slack_runner.py -q # 4 passed, 4 warningsAlso ran:
Manual End-to-End (E2E) Tests:
Not run. The unit test covers the reported Slack thread timestamp shape and verifies that
Runner.run_asyncreceives a managed-session-safe ID while Slack replies still use the originalthread_ts.Checklist
Additional context
The focused regression uses
thread_ts="1234567890.123456"and expectssession_id="C67890-1234567890_123456".