Main#28442
Conversation
- Updated eslint to use caret versioning for flexibility. - Upgraded vitest to version 3.2.7. - Replaced @modelcontextprotocol/sdk with a newer version (1.29.0). - Added new dependencies: @google-cloud/logging, @google-cloud/storage, @grpc/grpc-js, @opentelemetry/exporter-logs-otlp-grpc, @opentelemetry/sdk-metrics, @opentelemetry/sdk-trace-base, @vitest/coverage-v8, ajv, js-yaml, picomatch, shell-quote, simple-git, systeminformation, tar, undici, ws. - Created new mcp configuration file for markitdown server setup.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on standardizing and upgrading core dependencies across the entire monorepo. By aligning versions for critical infrastructure like OpenTelemetry, MCP, and utility libraries, the changes ensure better consistency and compatibility across all packages. Additionally, it introduces new MCP server support for improved developer tooling integration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/XL
|
There was a problem hiding this comment.
Code Review
This pull request adds a .vscode/mcp.json configuration file and updates dependencies across multiple packages in the monorepo. The review feedback highlights several critical dependency issues: @vitest/coverage-v8 (a testing tool) was incorrectly added to production dependencies instead of devDependencies across multiple packages, @google-cloud/storage was downgraded from v7 to v5 (which could introduce breaking changes), and there are version inconsistencies for ajv and vitest across different packages.
Note: Security Review has been skipped due to the limited scope of the PR.
| "@a2a-js/sdk": "0.3.11", | ||
| "@google-cloud/storage": "7.19.0", | ||
| "@google-cloud/logging": "^11.3.0", | ||
| "@google-cloud/storage": "^5.18.3", |
There was a problem hiding this comment.
Downgrading @google-cloud/storage from 7.19.0 to ^5.18.3 is a major version downgrade (v7 to v5). This is highly likely to introduce breaking changes and runtime errors, especially since the package was previously on v7. Please keep it at ^7.19.0 to align with the intended version in the monorepo.
| "@google-cloud/storage": "^5.18.3", | |
| "@google-cloud/storage": "^7.19.0", |
References
- When updating a dependency in package.json, ensure the version specified accurately reflects the intended version, especially if the package-lock.json resolves to a different version. If the package-lock.json shows a specific version (e.g., 0.16.1), and that is the desired version, then the package.json should be updated to match that exact version (e.g., ^0.16.1).
| "@opentelemetry/sdk-trace-base": "2.9.0", | ||
| "@vitest/coverage-v8": "^3.2.7", | ||
| "ajv": "8.20.0", |
There was a problem hiding this comment.
@vitest/coverage-v8 is a testing coverage tool and should not be included in production dependencies. It should be removed from dependencies to prevent bloating the production bundle.
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "@vitest/coverage-v8": "^3.2.7", | |
| "ajv": "8.20.0", | |
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "ajv": "8.20.0", |
References
- Before removing a dependency, perform a global search across the entire codebase to ensure it is not being used. An analysis limited to a few files may be incomplete.
| "@types/html-to-text": "9.0.4", | ||
| "@vitest/coverage-v8": "^3.2.7", | ||
| "@xterm/headless": "5.5.0", |
There was a problem hiding this comment.
@vitest/coverage-v8 is a testing coverage tool and should not be included in production dependencies. It should be removed from dependencies to prevent bloating the production bundle. Since it is already defined in the root package.json's devDependencies, it does not need to be added to individual packages.
| "@types/html-to-text": "9.0.4", | |
| "@vitest/coverage-v8": "^3.2.7", | |
| "@xterm/headless": "5.5.0", | |
| "@types/html-to-text": "9.0.4", | |
| "@xterm/headless": "5.5.0", |
References
- Before removing a dependency, perform a global search across the entire codebase to ensure it is not being used. An analysis limited to a few files may be incomplete.
| "@opentelemetry/sdk-trace-base": "2.9.0", | ||
| "@vitest/coverage-v8": "^3.2.7", | ||
| "ajv": "8.20.0", |
There was a problem hiding this comment.
@vitest/coverage-v8 is a testing coverage tool and should not be included in production dependencies. It should be removed from dependencies to prevent bloating the production bundle.
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "@vitest/coverage-v8": "^3.2.7", | |
| "ajv": "8.20.0", | |
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "ajv": "8.20.0", |
References
- Before removing a dependency, perform a global search across the entire codebase to ensure it is not being used. An analysis limited to a few files may be incomplete.
| "@opentelemetry/sdk-trace-base": "2.9.0", | ||
| "@vitest/coverage-v8": "^3.2.7", | ||
| "ajv": "8.20.0", |
There was a problem hiding this comment.
@vitest/coverage-v8 is a testing coverage tool and should not be included in production dependencies. It should be removed from dependencies to prevent bloating the production bundle.
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "@vitest/coverage-v8": "^3.2.7", | |
| "ajv": "8.20.0", | |
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "ajv": "8.20.0", |
References
- Before removing a dependency, perform a global search across the entire codebase to ensure it is not being used. An analysis limited to a few files may be incomplete.
| "@opentelemetry/sdk-trace-base": "2.9.0", | ||
| "@vitest/coverage-v8": "^3.2.7", | ||
| "ajv": "8.20.0", |
There was a problem hiding this comment.
@vitest/coverage-v8 is a testing coverage tool and should not be included in production dependencies. It should be removed from dependencies to prevent bloating the production bundle.
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "@vitest/coverage-v8": "^3.2.7", | |
| "ajv": "8.20.0", | |
| "@opentelemetry/sdk-trace-base": "2.9.0", | |
| "ajv": "8.20.0", |
References
- Before removing a dependency, perform a global search across the entire codebase to ensure it is not being used. An analysis limited to a few files may be incomplete.
| "@vitest/coverage-v8": "^3.2.7", | ||
| "@xterm/headless": "5.5.0", | ||
| "ajv": "8.17.1", | ||
| "ajv": "^8.17.1", |
There was a problem hiding this comment.
The version of ajv is set to ^8.17.1, which is inconsistent with the rest of the monorepo where it is resolved to 8.20.0. Please update it to ^8.20.0 to ensure consistency and avoid potential runtime issues.
| "ajv": "^8.17.1", | |
| "ajv": "^8.20.0", |
References
- When updating a dependency in package.json, ensure the version specified accurately reflects the intended version, especially if the package-lock.json resolves to a different version. If the package-lock.json shows a specific version (e.g., 0.16.1), and that is the desired version, then the package.json should be updated to match that exact version (e.g., ^0.16.1).
| "supertest": "7.1.4", | ||
| "typescript": "5.8.3", | ||
| "vitest": "3.2.4" | ||
| "vitest": "^3.1.1" |
There was a problem hiding this comment.
The version of vitest is set to ^3.1.1, which is inconsistent with the rest of the monorepo where it is ^3.2.7. Please align the version to ^3.2.7 to ensure consistency.
| "vitest": "^3.1.1" | |
| "vitest": "^3.2.7" |
References
- When updating a dependency in package.json, ensure the version specified accurately reflects the intended version, especially if the package-lock.json resolves to a different version. If the package-lock.json shows a specific version (e.g., 0.16.1), and that is the desired version, then the package.json should be updated to match that exact version (e.g., ^0.16.1).
| }, | ||
| "dependencies": { | ||
| "@google-cloud/logging": "11.3.0", | ||
| "@google-cloud/storage": "^5.18.3", |
There was a problem hiding this comment.
Using @google-cloud/storage version ^5.18.3 is inconsistent with other packages in the monorepo. Please use a consistent version like ^7.19.0 across all packages to avoid version mismatches and potential runtime errors, ensuring the version specified accurately reflects the intended version.
| "@google-cloud/storage": "^5.18.3", | |
| "@google-cloud/storage": "^7.19.0", |
References
- When updating a dependency in package.json, ensure the version specified accurately reflects the intended version, especially if the package-lock.json resolves to a different version. If the package-lock.json shows a specific version (e.g., 0.16.1), and that is the desired version, then the package.json should be updated to match that exact version (e.g., ^0.16.1).
…ed/gemini-cli-instincts.yaml)
feat: add gemini-cli ECC bundle
…jrq7j47355px Merge pull request #1 from devops2626/glorios
Merge branch 'google-gemini:main' into glorios
Merge branch 'google-gemini:main' into ecc-tools/gemini-cli-178452507…
…jrq7j47355px Merge branch 'google-gemini:main' into codespace-effective-disco-6v9g…
Bumps the npm_and_yarn group with 1 update in the /tools/caretaker-agent/cloudrun/ingestion-service directory: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `vitest` from 1.6.1 to 4.1.10 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.10/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 4.1.10 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…aretaker-agent/cloudrun/ingestion-service/npm_and_yarn-bc9680511c chore(deps-dev): bump vitest from 1.6.1 to 4.1.10 in /tools/caretaker-agent/cloudrun/ingestion-service in the npm_and_yarn group across 1 directory
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist