fix(integrations): declare PiIntegration multi_install_safe#3652
Open
jawwad-ali wants to merge 2 commits into
Open
fix(integrations): declare PiIntegration multi_install_safe#3652jawwad-ali wants to merge 2 commits into
jawwad-ali wants to merge 2 commits into
Conversation
PiIntegration writes only to its isolated, static root .pi/prompts, disjoint from every other integration, yet never declared multi_install_safe — so it inherited the IntegrationBase default False, leaving `specify integration status` in a permanent unsafe-multi-install ERROR state when pi is co-installed alongside another agent. Add `multi_install_safe = True`, mirroring the isolated MarkdownIntegration cohort (qwen, shai, qodercli) and the kiro-cli github#3471 fix. The parametrized registry isolation contracts auto-include pi and pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Declares Pi safe for concurrent installation with isolated integrations.
Changes:
- Enables
multi_install_safefor Pi. - Adds regression coverage for the declaration.
- Public integration reference still needs updating.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/pi/__init__.py |
Enables safe multi-install behavior. |
tests/integrations/test_integration_pi.py |
Verifies the safety declaration. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Collaborator
|
Please address Copilot feedback |
Declaring PiIntegration multi_install_safe means the reference table in docs/reference/integrations.md (which states it lists all currently declared multi-install-safe integrations) should include it. Add the alphabetized pi row with its .pi/prompts isolation path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Thanks! The Copilot feedback is addressed in b958aba: added the alphabetized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PiIntegrationwrites only to its isolated, static root.pi/prompts— disjoint from every other integration — yet never declaredmulti_install_safe, so it inherited theIntegrationBasedefaultFalse.Why it matters
Like the merged kiro-cli fix #3471, an isolated-but-undeclared integration leaves
specify integration statusin a permanentunsafe-multi-installERROR state when pi is co-installed alongside another agent, with no acknowledgment path. Pi meets none of the documented exclusion criteria (no shared command dir, no dynamic path, no merged settings). Every sibling isolatedMarkdownIntegrationgot the flag in the #2389 rollout; pi was skipped.Fix
Add
multi_install_safe = True, mirroringqwen/shai/qodercliand the kiro-cli #3471 precedent.Tests
test_integration_pi.py::TestPiIntegration::test_multi_install_safe(fails before the fix). The parametrized registry isolation contracts auto-include pi once the flag is set and pass —.pi/promptsis isolated and its manifest disjoint.ruffclean.AI-assisted: authored with Claude Code. Verified
.pi/is unique across all integrations and the isolation contracts pass with the flag set.