Skip to content

fix: bump Node.js from 20 to 22 in build-ui action#2935

Merged
SamMorrowDrums merged 1 commit into
dependabot/npm_and_yarn/ui/npm_and_yarn-38ebfa8954from
copilot/fix-npm-dependency-bug
Jul 23, 2026
Merged

fix: bump Node.js from 20 to 22 in build-ui action#2935
SamMorrowDrums merged 1 commit into
dependabot/npm_and_yarn/ui/npm_and_yarn-38ebfa8954from
copilot/fix-npm-dependency-bug

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes mcp-diff and mcp-diff-http CI failures caused by mcp-server-diff v3.0.0 requiring Node.js 22+, while the build-ui action was still setting up Node 20.

Why

SamMorrowDrums/mcp-server-diff@40d992e0a220e5b63378758f9a40d6a8982898d2 (v3.0.0) bundles undici 8, which calls webidl.util.markAsUncloneable — only available in Node.js 21+. The composite action inherits whatever node is in PATH, so the Node 20 set up by build-ui caused an immediate crash:

TypeError: webidl.util.markAsUncloneable is not a function

Node 20 also reached EOL on 2026-04-30.

What changed

  • .github/actions/build-ui/action.yml: node-version: "20""22"

MCP impact

  • No tool or API changes

Prompts tested (tool changes only)

Security / limits

  • No security or limits impact

Tool renaming

  • I am not renaming tools as part of this PR

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed

Copilot AI requested a review from SamMorrowDrums July 23, 2026 06:51
@SamMorrowDrums
SamMorrowDrums marked this pull request as ready for review July 23, 2026 09:08
@SamMorrowDrums
SamMorrowDrums requested a review from a team as a code owner July 23, 2026 09:08
Copilot AI review requested due to automatic review settings July 23, 2026 09:08
@SamMorrowDrums
SamMorrowDrums merged commit c75548b into dependabot/npm_and_yarn/ui/npm_and_yarn-38ebfa8954 Jul 23, 2026
13 of 16 checks passed
@SamMorrowDrums
SamMorrowDrums deleted the copilot/fix-npm-dependency-bug branch July 23, 2026 09:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the shared UI build action to target Node.js 22 for CI compatibility.

Changes:

  • Changes actions/setup-node from Node.js 20 to 22.
Show a summary per file
File Description
.github/actions/build-ui/action.yml Updates the configured Node.js version.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Medium

uses: actions/setup-node@v6
with:
node-version: "20"
node-version: "22"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants