ref(core): Ensure error span status is always valid#22522
Open
mydea wants to merge 3 commits into
Open
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7bd130c. Configure here.
|
|
||
| export function isStatusErrorMessageValid(message: string): boolean { | ||
| return SPAN_STATUS_TYPES.includes(message as SpanStatusType); | ||
| } |
There was a problem hiding this comment.
Ok accepted as error status
Low Severity
isStatusErrorMessageValid now checks membership in SPAN_STATUS_TYPES, which includes 'ok'. For a span with error code and message 'ok', getStatusMessage and mapStatus treat that message as valid, so legacy transaction serialization can emit status: 'ok' for an error span instead of normalizing to 'internal_error'.
Reviewed by Cursor Bugbot for commit 7bd130c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some code in otel span serialization that ensures that span statuses are correct. if we remove this layer, however we can "invalid" span statuses (e.g. random error messages etc). This change ensures we always have valid span statuses everywhere, in the legacy transaction mode.