Cleanup: Simplify open document#1773
Open
jeremypw wants to merge 13 commits into
Open
Conversation
This reverts commit 3a5e5fb.
jeremypw
marked this pull request as ready for review
July 22, 2026 17:08
Member
|
@jeremypw can you resolve conflicts please |
# Conflicts: # src/MainWindow.vala
jeremypw
marked this pull request as draft
July 22, 2026 17:49
Collaborator
Author
|
Converting back to draft for testing after tricky merge |
jeremypw
marked this pull request as ready for review
July 22, 2026 18:13
danirabbit
reviewed
Jul 22, 2026
| // to confine Document creation to this class. | ||
| // Documents are treated the same regarding the focus, cursor_position and range parameters | ||
| // whether already open or not. | ||
| // Cursor position may have any value > -2 to set cursor. Lower values are ignored (default) |
Collaborator
Author
There was a problem hiding this comment.
Because -1 and 0 are valid values, sending the cursor to the start or end of the document. So I chose -2 or anything more negative to mean leave the cursor where it is.
danirabbit
reviewed
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foldermanagerview member of window is temporarily made public but after #1778 this will not be necessary as that function will be moved to GitManager