Add full_offers option to Compute.get_offers()#4060
Open
un-def wants to merge 1 commit into
Open
Conversation
When set to `True`, instructs the Compute not to adjust offers by requirements. Ignored by all backends except for Kubernetes and Slurm, which return full allocatable node resources if `True` or a purely synthetic offer reflecting resources that would be actually requested if `False` (the old/current default behavior). Exposed as `full_offers` request body argument in HTTP API and `--full-offers` flag in `dstack apply`/`dstack offer` commands.
r4victor
reviewed
Jul 23, 2026
| if `full_offers` set to `True`, the method should not adjust offer's resources according to | ||
| `requirements`. For most backends, this flag has no meaning, as they work with predefined | ||
| provider offers (even configurable disk size reflects the actual disk created once the | ||
| instance is provisioned), but some backends such as Kubernetes and Slurm allocates flexible |
Collaborator
There was a problem hiding this comment.
Suggested change
| instance is provisioned), but some backends such as Kubernetes and Slurm allocates flexible | |
| instance is provisioned), but some backends such as Kubernetes and Slurm allocate flexible |
r4victor
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When set to
True, instructs the Compute not to adjust offers by requirements. Ignored by all backends except for Kubernetes and Slurm, which return full allocatable node resources ifTrueor a purely synthetic offer reflecting resources that would be actually requested ifFalse(the old/current default behavior).Exposed as
full_offersrequest body argument in HTTP API and--full-offersflag indstack apply/dstack offercommands.