Skip to content

fix(terminology): prevent path traversal in Excel upload #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastiondev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(terminology): prevent path traversal in Excel upload #1284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions backend/apps/terminology/api/terminology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,15 @@ async def upload_excel(trans: Trans, current_user: CurrentUser, file: UploadFile
raise HTTPException(400, "Only support .xlsx/.xls")

os.makedirs(path, exist_ok=True)
base_filename = f"{file.filename.split('.')[0]}_{hashlib.sha256(uuid.uuid4().bytes).hexdigest()[:10]}"
filename = f"{base_filename}.{file.filename.split('.')[1]}"
save_path = os.path.join(path, filename)
# Strip any directory components from the client-supplied filename to
# prevent path traversal (CWE-22).
safe_name = os.path.basename(file.filename)
name_root, name_ext = os.path.splitext(safe_name)
base_filename = f"{name_root}_{hashlib.sha256(uuid.uuid4().bytes).hexdigest()[:10]}"
filename = f"{base_filename}{name_ext}"
save_path = os.path.realpath(os.path.join(path, filename))
if os.path.commonpath([save_path, os.path.realpath(path)]) != os.path.realpath(path):
raise HTTPException(400, "Invalid filename")
with open(save_path, "wb") as f:
f.write(await file.read())

Expand Down Expand Up @@ -262,7 +268,9 @@ def inner():

df = pd.DataFrame(md_data, columns=_fields_list)
error_excel_filename = f"{base_filename}_error.xlsx"
save_error_path = os.path.join(path, error_excel_filename)
save_error_path = os.path.realpath(os.path.join(path, error_excel_filename))
if os.path.commonpath([save_error_path, os.path.realpath(path)]) != os.path.realpath(path):
raise Exception("Invalid filename")
# 保存 DataFrame 到 Excel
df.to_excel(save_error_path, index=False)

Expand Down
Loading