Fix #14899: FP invalidPrintfArgType_float with _sprintf_s_l() #8729
Open
ludviggunne wants to merge 4 commits into
Open
Fix #14899: FP invalidPrintfArgType_float with _sprintf_s_l() #8729ludviggunne wants to merge 4 commits into
ludviggunne wants to merge 4 commits into
Conversation
ludviggunne
force-pushed
the
14899-sprintf
branch
from
July 15, 2026 13:38
291628b to
a956174
Compare
ludviggunne
force-pushed
the
14899-sprintf
branch
from
July 15, 2026 14:00
a956174 to
72718dd
Compare
| "[test.cpp:17:5]: (warning) %s in format string (no. 5) requires 'char *' but the argument type is 'signed int'. [invalidPrintfArgType_s]\n" | ||
| "[test.cpp:17:5]: (warning) sprintf_s format string requires 5 parameters but 6 are given. [wrongPrintfScanfArgNum]\n", errout_str()); | ||
|
|
||
| check("int main()\n" |
Collaborator
There was a problem hiding this comment.
This test seems redundant and also ineffective since windows.cfg is not loaded.
Edit: scratch that, those are tests of the Windows functions. So the test in windows.cpp might as well be removed.
| const size_t buffer_size = 64; | ||
| char buffer[buffer_size]; | ||
| int precision = 2; | ||
| // cppcheck-suppress [checkLibraryFunction,valueFlowBailoutIncompleteVar] |
Collaborator
There was a problem hiding this comment.
If you want to go the extra mile, adding configuration for those two function would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.