Run lib.profiler unit tests in CI#9526
Conversation
997f715 to
d9a1a8f
Compare
|
Thanks for taking care. Would you please squash the commits? As @mbien followed the same instinct as I did ( netbeans/.github/workflows/main.yml Line 1626 in 43e7905 That way the label |
Should I keep the |
Add condition to run `profiler-test` with `profiler` label. Stabilize lib.profiler heap dump output Assisted-by: OpenAI GPT-5 Codex
d9a1a8f to
b9ad583
Compare
This follows up on the review discussion in #9497 by adding the
profiler/lib.profilerunit tests to the main CI workflow.The new CI step runs the existing
test-unittarget while disabling compilation of the legacy QA-functional source set, which is not executed by that target.The legacy CPU snapshot tests now use deterministic
SampledThreadInfofixtures for the builder logic. A focused test still exercises the publicThreadInfo[]adapter with data fromThreadMXBean, without relying on private JDK constructors, fields, or internalsun.managementclasses.The heap-dump golden output is made deterministic by sorting system-property names and escaping embedded line breaks. The golden file is refreshed for that stable representation and the current JVM's floating-point string representation.
Validation:
69 tests passed with no failures or errors.
Assisted-by: OpenAI GPT-5 Codex
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)