Fix incorrect absolute minimum calculation#7536
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7536 +/- ##
=========================================
Coverage 80.32% 80.32%
- Complexity 7402 7406 +4
=========================================
Files 812 812
Lines 23911 23914 +3
Branches 4704 4706 +2
=========================================
+ Hits 19206 19210 +4
Misses 3944 3944
+ Partials 761 760 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@klerk1t Nice simplification! I found one remaining edge case though.
AbsoluteMin.getMinValue(Integer.MIN_VALUE, 1)currently return I'd recommend comparing absolute values as |
|
@DenizAltunkapan Thanks for pointing this out! I've updated the implementation to avoid the |
DenizAltunkapan
left a comment
There was a problem hiding this comment.
@klerk1t thank you for your contribution 🙂
clang-format -i --style=file path/to/your/file.java