Skip to content

[dm][ethernet] Add ethernet and drivers for DM#11641

Open
GuEe-GUI wants to merge 3 commits into
RT-Thread:masterfrom
GuEe-GUI:eth
Open

[dm][ethernet] Add ethernet and drivers for DM#11641
GuEe-GUI wants to merge 3 commits into
RT-Thread:masterfrom
GuEe-GUI:eth

Conversation

@GuEe-GUI

@GuEe-GUI GuEe-GUI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[

  1. Add ethernet port for DM
  2. Improve PHY v2 support and add RTL8211F driver
  3. Add MACB and DWMAC ethernet support

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/ethernet/Kconfig
  • components/drivers/ethernet/SConscript
  • components/drivers/ethernet/cadence/Kconfig
  • components/drivers/ethernet/cadence/SConscript
  • components/drivers/ethernet/cadence/macb.c
  • components/drivers/ethernet/cadence/macb.h
  • components/drivers/ethernet/cadence/macb_pci.c
  • components/drivers/ethernet/cadence/macb_phy.c
  • components/drivers/ethernet/cadence/macb_ptp.c
  • components/drivers/ethernet/ethernet_dm.c
  • components/drivers/ethernet/ethernet_dm.h
  • components/drivers/ethernet/synopsys/Kconfig
  • components/drivers/ethernet/synopsys/SConscript
  • components/drivers/ethernet/synopsys/dwmac-platform.c
  • components/drivers/ethernet/synopsys/dwmac-platform.h
  • components/drivers/ethernet/synopsys/dwmac.c
  • components/drivers/ethernet/synopsys/dwmac.h
  • components/drivers/ethernet/synopsys/dwmac_ptp.c
  • components/drivers/ethernet/synopsys/dwmac_ptp.h
  • components/drivers/phy/Kconfig
  • components/drivers/phy/SConscript
  • components/drivers/phy/general.c
  • components/drivers/phy/mdio.c
  • components/drivers/phy/ofw.c
  • components/drivers/phy/phy-realtek.c
  • components/drivers/phy/phy.c

📊 Current Review Status (Last Updated: 2026-07-23 09:54 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:eth
  • 设置PR number为 \ Set the PR number to:11641
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 eth 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the eth branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Device-Model (DM) based Ethernet driver infrastructure to RT-Thread, improves PHY v2 handling, and introduces new MAC/PHY driver implementations (Cadence MACB/GEM and Synopsys DWMAC, plus Realtek RTL8211F PHY).

Changes:

  • Add a new DM Ethernet driver framework and build/Kconfig integration under components/drivers/ethernet/.
    新增基于 DM 的以太网驱动框架,并补齐对应的构建与 Kconfig 集成。
  • Improve PHY v2 support, including better OFW PHY-id discovery and a new Realtek RTL8211F PHY driver.
    完善 PHY v2 支持(含 OFW 兼容匹配/MDIO 读取兜底),并新增 RTL8211F PHY 驱动。
  • Add new Ethernet MAC drivers: Cadence MACB/GEM and Synopsys DesignWare GMAC4 (DWMAC) with optional PTP.
    新增 Cadence MACB/GEM 与 Synopsys DWMAC(可选 PTP)MAC 驱动实现。

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
components/drivers/phy/SConscript Adjust PHY source selection and add conditional Realtek PHY build.
components/drivers/phy/phy.c Fix PHY mask scanning loop; initialize supported/advertising for genphy fallback.
components/drivers/phy/phy-realtek.c Add RTL8211F PHY driver implementation.
components/drivers/phy/ofw.c Improve OFW PHY-id parsing (multi-compatible) and add MDIO PHY-id fallback.
components/drivers/phy/mdio.c Use zero-initializing allocation for mii_bus.
components/drivers/phy/Kconfig Add Realtek PHY v2 option.
components/drivers/phy/general.c Update genphy link update logic and error propagation.
components/drivers/ethernet/SConscript Add Ethernet driver group build entry and subdir discovery.
components/drivers/ethernet/Kconfig Add Ethernet driver menu and per-vendor Kconfig includes.
components/drivers/ethernet/ethernet_dm.h Add common Ethernet DM helpers (random MAC API).
components/drivers/ethernet/ethernet_dm.c Implement random MAC address generation helper.
components/drivers/ethernet/cadence/SConscript Add Cadence MACB/GEM driver build integration.
components/drivers/ethernet/cadence/Kconfig Add Cadence MACB/GEM Kconfig entries (PCI/PTP options).
components/drivers/ethernet/cadence/macb.h Add MACB/GEM register definitions and driver structs.
components/drivers/ethernet/cadence/macb.c Add MACB/GEM Ethernet MAC driver implementation.
components/drivers/ethernet/cadence/macb_phy.c Add MACB MDIO/PHY handling helpers.
components/drivers/ethernet/cadence/macb_ptp.c Add MACB/GEM PTP support implementation.
components/drivers/ethernet/cadence/macb_pci.c Add PCI wrapper driver for MACB/GEM.
components/drivers/ethernet/synopsys/SConscript Add Synopsys DWMAC driver build integration.
components/drivers/ethernet/synopsys/Kconfig Add Synopsys DWMAC Kconfig entries (PTP option).
components/drivers/ethernet/synopsys/dwmac.h Add DWMAC register/descriptor definitions and driver structs.
components/drivers/ethernet/synopsys/dwmac.c Add DWMAC Ethernet MAC driver implementation.
components/drivers/ethernet/synopsys/dwmac-platform.h Add DWMAC platform registration API.
components/drivers/ethernet/synopsys/dwmac-platform.c Add DWMAC platform glue (iomap/irq/mac address).
components/drivers/ethernet/synopsys/dwmac_ptp.h Add DWMAC PTP register definitions and API.
components/drivers/ethernet/synopsys/dwmac_ptp.c Add DWMAC PTP support implementation.

Comment thread components/drivers/ethernet/ethernet_dm.c Outdated
Comment thread components/drivers/ethernet/synopsys/dwmac.c Outdated
Comment thread components/drivers/ethernet/Kconfig
GuEe-GUI added 3 commits July 23, 2026 09:49
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
They support PTP, too.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI

Copy link
Copy Markdown
Contributor Author

@Rbb666 审核建议已修改完成

@BernardXiong

Copy link
Copy Markdown
Member

@GuEe-GUI 验证情况还麻烦补充下,谢谢

@GuEe-GUI

GuEe-GUI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

目前在树莓派5b + BCM54213 PHY和zynqmp-a53-dfzu2eg (仅QEMU)下MACB 可正常工作,DWMAC + RTL phy 基于rk3568正常工作,phy 框架均在前面提到的平台,以及 Spacemit K1 和树莓派4b 上验证通过

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants