Skip to content

Reintroduce support for CLI option to disable blocking kernel#429

Open
oleksandr-pavlyk wants to merge 4 commits into
NVIDIA:mainfrom
oleksandr-pavlyk:re-add-CLI-disable-blocking-kernel-option
Open

Reintroduce support for CLI option to disable blocking kernel#429
oleksandr-pavlyk wants to merge 4 commits into
NVIDIA:mainfrom
oleksandr-pavlyk:re-add-CLI-disable-blocking-kernel-option

Conversation

@oleksandr-pavlyk

Copy link
Copy Markdown
Collaborator

This PR reintroduced --disable-blocking-kernel CLI option at downstream user's request.

I was removed in #254, to disallow specifying once existing --run-once option without using --disable-blocking-kernel.

Closes #425

@oleksandr-pavlyk

Copy link
Copy Markdown
Collaborator Author

@mfranzrebsal for viz.

Comment thread docs/cli_help.md Outdated
Comment thread testing/option_parser.cu Outdated
@oleksandr-pavlyk

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai

This comment was marked as outdated.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d048d8ca-2600-4313-b9cd-f89166d2e44c

📥 Commits

Reviewing files that changed from the base of the PR and between 84ce36c and 7baa3fc.

📒 Files selected for processing (5)
  • docs/cli_help.md
  • nvbench/blocking_kernel.cu
  • nvbench/option_parser.cu
  • nvbench/option_parser.cuh
  • testing/option_parser.cu

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added the --disable-blocking-kernel command-line option to disable blocking-kernel timing for cold measurements while keeping repeated benchmark runs intact.
    • The setting applies to the most recent selected benchmark, or globally for benchmarks specified after the flag.
    • Updated deadlock/profiling guidance to reflect the correct combination of options for repeated execution.
  • Documentation
    • Added CLI help documentation for --disable-blocking-kernel.
  • Tests
    • Added coverage verifying option parsing, ordering behavior, and interaction with --profile.

Walkthrough

Changes

Blocking-kernel CLI support

Layer / File(s) Summary
Parse and apply the option
nvbench/option_parser.cuh, nvbench/option_parser.cu
The parser recognizes --disable-blocking-kernel, stores it for future benchmarks when none is selected, or applies it to the latest benchmark.
Validate and document behavior
testing/option_parser.cu, docs/cli_help.md, nvbench/blocking_kernel.cu
Tests cover option ordering and profile interactions; help and deadlock diagnostics describe the option’s behavior.

Assessment against linked issues

Objective Addressed Explanation
Restore CLI support for independently disabling the blocking kernel [#425]

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@oleksandr-pavlyk
oleksandr-pavlyk force-pushed the re-add-CLI-disable-blocking-kernel-option branch from f3e9552 to 88c8789 Compare July 21, 2026 18:16
@oleksandr-pavlyk

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore support for CLI option --disable-blocking-kernel

1 participant