fix - windows compatibility#59
Open
JayWiz wants to merge 2 commits into
Open
Conversation
Collaborator
|
/ok to test 34f08c3 |
hsahuja0805
reviewed
Jul 22, 2026
Collaborator
There was a problem hiding this comment.
Please use the resolved executable instead of the bare name since it will fail for some cases on Windows. Instead of ncu here, assign shutil.which("ncu") or "ncu" to a variable and use that instead.
In test_collection.py:test_launch_ncu_runs_with_ncu_available test
With the shutil.which change here , cmd[0] is the resolved path, so patch shutil.which (e.g. @patch("shutil.which", return_value="resolved-ncu")) and assert "resolved-ncu" here.
hsahuja0805
requested changes
Jul 22, 2026
….de> Fix Windows Compatibility
hsahuja0805
force-pushed
the
fix/windows-compatibility
branch
from
July 23, 2026 10:40
34f08c3 to
fa6d0bb
Compare
Collaborator
|
/ok to test fa6d0bb |
nvssatoor
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor change to ensure windows compatibility in v1.0.0