[CHA-2957] Java: sync generated client and wire structured logging#74
Merged
Conversation
Regenerated from chat master. Removes the 4 external-storage importer endpoints (/imports/v2/external-storage get/upsert/delete/validate) that CHA-3889 gated as private/operator-only and hid from the public OpenAPI spec; adds importBlockList; adds an id path param to getModerationRule/deleteModerationRule; refreshes assorted model fields. Generated Impls keep the existing StreamRequest constructor, so no behavior change.
Regenerated with the updated java template: the generated *Impl clients now construct StreamRequest with the StreamHTTPClient (instead of its httpClient/objectMapper/baseUrl getters), so the client-level SLF4J logger reaches the request layer and the CHA-2957 logging events fire on real API calls. No behavior change beyond logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/CHA-2957/logging
Summary
Regenerates the Java SDK against chat master and wires the CHA-2957 structured logging through the generated service clients. Two commits, reviewable separately:
chore: sync generated client to chat master API— pure regen against current chat master. Removes the 4 external-storage importer endpoints (/imports/v2/external-storageget/upsert/delete/validate) that [CHA-3889] / #14776 gated as private/operator-only and hid from the public OpenAPI spec (Ignore: true; still routed but behind theexternal_storage_importfeature flag). AddsimportBlockList. Adds anidpath param togetModerationRule/deleteModerationRule. Refreshes assorted model fields. No behavior change: the generated Impls still use the existingStreamRequestconstructor.feat: wire structured logging through the generated service clients— regenerated with the updated Java template so the generated*Implclients constructStreamRequestwith theStreamHTTPClient. This lets the client-level SLF4J logger reach the request layer, so the CHA-2957 logging events fire on real API calls (they were framework-only before this).Notes for review
NotAllowedwithout the feature flag regardless.release-*branch flow. Publish later via the manual Release workflow when ready.